varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: synchronize access to tid symbols hashtable

Browse Source 
This can get mutated after the document is loaded, so we need to
synchronize access to it.
This commit is contained in:
Christian Hergert
2023-08-06 02:18:43 -07:00
parent 9cbfc21363
commit fe4995cf1f
1 changed files with 26 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libsysprof/sysprof-document.c
View File

@ -2102,10 +2102,19 @@ _sysprof_document_thread_symbol (SysprofDocument *self,
int pid, int pid,
int tid) int tid)
{ {
static GRWLock rwlock;
SysprofSymbol *ret; SysprofSymbol *ret;
g_return_val_if_fail (SYSPROF_IS_DOCUMENT (self), NULL); g_return_val_if_fail (SYSPROF_IS_DOCUMENT (self), NULL);
g_rw_lock_reader_lock (&rwlock);
ret = g_hash_table_lookup (self->tid_to_symbol, GINT_TO_POINTER (tid));
g_rw_lock_reader_unlock (&rwlock);
if (ret == NULL)
{
g_rw_lock_writer_lock (&rwlock);
if (!(ret = g_hash_table_lookup (self->tid_to_symbol, GINT_TO_POINTER (tid)))) if (!(ret = g_hash_table_lookup (self->tid_to_symbol, GINT_TO_POINTER (tid))))
{ {
char pidstr[32]; char pidstr[32];
@ -2127,6 +2136,9 @@ _sysprof_document_thread_symbol (SysprofDocument *self,
g_hash_table_insert (self->tid_to_symbol, GINT_TO_POINTER (tid), ret); g_hash_table_insert (self->tid_to_symbol, GINT_TO_POINTER (tid), ret);
} }
g_rw_lock_writer_unlock (&rwlock);
}
return ret; return ret;
} }