varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-07 21:50:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: synchronize access to tid symbols hashtable

Browse Source 
This can get mutated after the document is loaded, so we need to
synchronize access to it.
This commit is contained in:
Christian Hergert
2023-08-06 02:18:43 -07:00
parent 9cbfc21363
commit fe4995cf1f
1 changed files with 26 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/libsysprof/sysprof-document.c
View File

@ -2102,29 +2102,41 @@ _sysprof_document_thread_symbol (SysprofDocument *self,
int pid, int pid,
int tid) int tid)
{ {
static GRWLock rwlock;
SysprofSymbol *ret; SysprofSymbol *ret;
g_return_val_if_fail (SYSPROF_IS_DOCUMENT (self), NULL); g_return_val_if_fail (SYSPROF_IS_DOCUMENT (self), NULL);
if (!(ret = g_hash_table_lookup (self->tid_to_symbol, GINT_TO_POINTER (tid)))) g_rw_lock_reader_lock (&rwlock);
ret = g_hash_table_lookup (self->tid_to_symbol, GINT_TO_POINTER (tid));
g_rw_lock_reader_unlock (&rwlock);
if (ret == NULL)
{ {
char pidstr[32]; g_rw_lock_writer_lock (&rwlock);
char tidstr[32];
g_snprintf (pidstr, sizeof pidstr, "(%d)", pid); if (!(ret = g_hash_table_lookup (self->tid_to_symbol, GINT_TO_POINTER (tid))))
{
char pidstr[32];
char tidstr[32];
if (tid == pid) g_snprintf (pidstr, sizeof pidstr, "(%d)", pid);
g_snprintf (tidstr, sizeof tidstr, "Thread-%d (Main)", tid);
else
g_snprintf (tidstr, sizeof tidstr, "Thread-%d", tid);
ret = _sysprof_symbol_new (g_ref_string_new (tidstr), if (tid == pid)
NULL, g_snprintf (tidstr, sizeof tidstr, "Thread-%d (Main)", tid);
g_ref_string_new (pidstr), else
0, 0, g_snprintf (tidstr, sizeof tidstr, "Thread-%d", tid);
SYSPROF_SYMBOL_KIND_THREAD);
g_hash_table_insert (self->tid_to_symbol, GINT_TO_POINTER (tid), ret); ret = _sysprof_symbol_new (g_ref_string_new (tidstr),
NULL,
g_ref_string_new (pidstr),
0, 0,
SYSPROF_SYMBOL_KIND_THREAD);
g_hash_table_insert (self->tid_to_symbol, GINT_TO_POINTER (tid), ret);
}
g_rw_lock_writer_unlock (&rwlock);
} }
return ret; return ret;