Commit Graph

82 Commits

Author SHA1 Message Date
f06e272ea7 Make the load_file() idle low priority to avoid weird toolbar flash.
2006-08-08  Soren Sandmann  <ssp@localhost.localdomain>

	* sysprof.c (main): Make the load_file() idle low priority to
	avoid weird toolbar flash.

	* TODO: updates.
2006-08-09 03:05:34 +00:00
23d3a36a4a small cleanup 2006-07-31 18:52:12 +00:00
d43cdf3c14 Add a destroy notifier to StackStash
2006-07-31  Soren Sandmann <sandmann@redhat.com>

	* stackstash.[ch]: Add a destroy notifier to StackStash

	* collector.c (collector_create_profile): Pass g_free as destroy
	notifier.

	* collector.c (collector_reset): Pass NULL as destroy notifier

	* profile.c (profile_load): Pass g_free here.

	* profile.c (struct Profile): Remove unused "Node" typedef

	* collector.c (resolve_symbols): Free the array here.

	* TODO: various updates.
2006-07-31 04:50:34 +00:00
849efc820d Do proper error-handling.
2006-03-05 Soeren Sandmann <sandmann@redhat.com>

        * sysprof-text.c, collector.c, sysprof.c: Do proper
        error-handling.
2006-03-05 21:11:07 +00:00
ebb7728768 Check that the inodes match.
Fri Mar  3 22:28:03 2006  Soeren Sandmann  <sandmann@redhat.com>

        * process.c (process_lookup_symbol): Check that the inodes match.

        * binfile.c (read_symbols): Read the inode of the file

        * binfile.c (read_symbols): Close the bfd if the symbol table
        could not be read.
2006-03-04 03:28:26 +00:00
0d6d997f4a Handle NULL models.
Thu Mar  2 22:54:37 2006  Soeren Sandmann  <sandmann@redhat.com>

        * treeviewutils.c (tree_view_foreach_visible): Handle NULL models.

        * sysprof.glade, sysprof.c: Revert back to three pane layout.
2006-03-03 03:55:04 +00:00
dc51fea3b4 Clear screenshot window when start is toggled.
Fri Feb 24 02:09:33 2006  Soeren Sandmann  <sandmann@redhat.com>

        * sysprof.c (on_start_toggled): Clear screenshot window when start
        is toggled.

        * TODO: Add some notes about stack handling on the x86
2006-02-24 07:10:42 +00:00
58a1cf37ef Remove ancestors pane in favor of radiobuttons in the right pane.
Sat Feb  4 23:53:05 2006  Søren Sandmann  <sandmann@redhat.com>

	* sysprof.glade: Remove ancestors pane in favor of radiobuttons in
	the right pane.

	* sysprof.c: Corresponding changes.

	* TODO: Updates
2006-02-05 04:54:04 +00:00
135ce0e2ea Updates
Sun Jan 15 00:24:02 2006  Soeren Sandmann  <sandmann@redhat.com>

        * TODO: Updates

        * sysprof.c (build_gui): Rename 'callers' column 'ancestors'

        * profile.c (profile_list_callers): Make this function list all
        ancestors of the function. Also make it report correct numbers
        again.
2006-01-15 05:28:04 +00:00
98308836af Only build GUI when the necessary dependencies are found.
Sat Jan 14 18:24:43 2006  Soeren Sandmann  <sandmann@redhat.com>

        * configure.ac, Makefile.am: Only build GUI when the necessary
        dependencies are found.

        * sysprof.c (compute_text_width): Remove unused variable

        * profile.c (build_object_list): Follow next instead of siblings.
2006-01-14 23:26:34 +00:00
f6d7a34ccf small updates cosmetic updates cosmetic updates
Thu Jan  5 17:52:10 2006  Søren Sandmann  <sandmann@redhat.com>

	* TODO: small updates
	* sysprof.c: cosmetic updates
	* module/sysprof-module.c: cosmetic updates
2006-01-05 22:52:59 +00:00
ad5ffd749b Dist and install udev rule.
2005-12-20  Kristian Høgsberg  <krh@redhat.com>

        * Makefile.am: Dist and install udev rule.

        * collector.c: (open_fd):
        * sysprof-text.c: (no_module):
        * sysprof.c: (on_start_toggled): Update device filename.

        * 60-sysprof.rules: New udev rule file to set permissions for
        sysprof char device.

        * module/sysprof-module.c: Switch kernel module to use a misc char
        device instead.  Start and stop the timer on device open and
        close instead of module load and unload.
2005-12-20 17:55:03 +00:00
02242d500b Make the tree tree-shapeed.
Mon Dec 19 17:39:09 2005  Søren Sandmann  <sandmann@redhat.com>

	* sysprof.c (add_text): Make the tree tree-shapeed.
2005-12-19 22:39:34 +00:00
35de8d36a0 New function. Update screenshot window when rows are expanded and
2005-11-29  Soeren Sandmann  <sandmann@redhat.com>

        * sysprof.c (on_descendants_row_expanded_or_collapsed): New
        function. Update screenshot window when rows are expanded and
        collapsed.
2005-11-30 07:12:32 +00:00
96188f3c99 Update the screenshot window.
2005-11-23  Soeren Sandmann  <sandmann@redhat.com>

	* sysprof.c (update_screenshot_window): Update the screenshot
	window.
2005-11-24 04:53:19 +00:00
b6e9105cd2 Put the vertical splitter at 3/8 * screen_width.
Sat Nov 12 23:39:29 2005  Soeren Sandmann  <sandmann@redhat.com>

        * sysprof.c (set_sizes): Put the vertical splitter at 3/8 *
        screen_width.

        * configure.ac: Disable warning.
2005-11-13 04:28:57 +00:00
c3ce4ef8c5 Add new tree_view_foreach_visible() function.
Wed Nov  9 00:24:11 2005  Soeren Sandmann  <sandmann@redhat.com>

        * treeviewutils.[ch]: Add new tree_view_foreach_visible()
        function.

        * sysprof.c: Add update_screenshot_window() function.
2005-11-09 05:39:25 +00:00
00244118a2 Add beginning of a screenshot window.
Mon Nov  7 23:42:26 2005  Soeren Sandmann  <sandmann@redhat.com>

        * sysprof.c: Add beginning of a screenshot
        window.

        * sysprof.glade: Add screenshot window plus menu items.

        * stackstash.c: Remove unused function stack_node_list_leaves()

        * xmlstore.c: Various crack
2005-11-08 04:32:19 +00:00
fe5dd1e1fa Sun Nov 6 Soeren Sandmann <sandmann@redhat.com>
Sun Nov  6  Soeren Sandmann  <sandmann@redhat.com>

        * TODO: updates

        * collector.c (on_read): Only call back when a new sample actually
        arrived.

        * collector.c (collector_stop): close the filedescriptor

        * sysprof.c (on_start_toggled): Change sense of test.

        * sysprof.c (ensure_profile): Stop the collector.

        * sysprof.c (on_reset_clicked): Stop the collector when state
        becomes INITIAL.
2005-11-07 02:27:55 +00:00
c1bfbbf9b8 Turn this function into a StackFunction.
Sun Nov  6 17:06:52 2005  Soeren Sandmann  <sandmann@redhat.com>

        * profile.c (add_trace_to_tree): Turn this function into a
        StackFunction.

        * stackstash.c (stack_node_foreach_trace): Make this function take
        a StackFunction, and reimplement with do_callback().
2005-11-06 22:10:30 +00:00
1f5b6ff38c Don't compute the total field.
Sat Nov  5 12:39:33 2005  Soeren Sandmann  <sandmann@redhat.com>

        * profile.c (add_trace_to_tree): Don't compute the total field.

        * profile.h (struct ProfileDescendant): Remove 'total' field.

        * sysprof.c: Delete DESCENDANTS_TOTAL column and everything
        related to it.

        * profile.c: Remove commented out code

        * sfile.c (handle_text): Don't copy the text
2005-11-05 17:28:22 +00:00
cf761a2a70 Add copyright statement.
2005-11-04  Soren Sandmann  <sandmann@redhat.com>

        * collector.[ch]: Add copyright statement.

        * collector.c (on_read): Handle time getting set backwards.

        * collector.c: Remove unused empty_filedescriptor() function.
2005-11-05 04:58:16 +00:00
5bddcf4af9 +2005-11-03 Soren Sandmann <sandmann@redhat.com>
+
+       * configure.ac: Make the message about the kernel source package
+       more informative. Code from Kjetil Torgrim Homme.
+
+       * sysprof.c (on_start_toggled): Only delete the data if the
+       profiling can actually be started.
+
2005-11-05 00:49:34 +00:00
4f270a0f48 Update GUI after showing error message.
2005-11-01  Soeren Sandmann  <sandmann@redhat.com>

        * sysprof.c (on_start_toggled): Update GUI after showing error
        message.

        * sysprof.glade: Rename File menu Profiler, move
        Start/Profile/Reset here, delete View menu.
2005-11-02 05:10:13 +00:00
81ad181667 free the profile objects.
Mon Oct 31 21:36:37 2005  Søren Sandmann  <sandmann@redhat.com>

        * sysprof.c (fill_main_list): free the profile objects.

        * sysprof.c (struct Application): Remove unused variable.
2005-11-01 02:37:09 +00:00
ec8798a8b1 Use APPLICATION_NAME macro
Mon Oct 31 00:22:58 2005  Soeren Sandmann  <sandmann@redhat.com>

	* sysprof.c (set_application_title): Use APPLICATION_NAME macro

	* sysprof.c (load_file): Don't leak the FileOpenData

	* TODO: updates
2005-10-31 05:20:37 +00:00
dff4affaab Merge stackstash-reorg branch into HEAD
2005-10-30  Soren Sandmann <sandmann@redhat.com>

	* Merge stackstash-reorg branch into HEAD
2005-10-30 20:14:31 +00:00
ba8f13a606 Fix crash pointed reported by Rudi Chiarito.
Sat Oct 29 14:43:00 2005  Søren Sandmann  <sandmann@redhat.com>

        Fix crash pointed reported by Rudi Chiarito.

        * stackstash.c (stack_stash_add_trace): Just return if
        n_addrs is 0.

        * sysprof.c (on_read): Only trace if n_addresses != 0.
2005-10-29 18:50:11 +00:00
f7e888e574 Revert accidental commit of stackstash reorganisation 2005-10-01 05:23:58 +00:00
cc1055d105 Update
Sat Oct  1 01:21:57 2005  Soeren Sandmann  <sandmann@redhat.com>

        * TODO: Update
2005-10-01 05:21:25 +00:00
e2fb3b2985 New non-GUI version, written by Lorenzo Colitti, with some changes by me.
Sat Sep 24 00:01:42 2005  Soeren Sandmann  <sandmann@redhat.com>

	* Nakefile.am, sysprof-text.c: New non-GUI version, written
	by Lorenzo Colitti, with some changes by me.

	* signal-handler.[ch]: New files that provide a way to get UNIX
	signals into a glib main loop.

	* README: add Lorenzo to credits
2005-09-24 04:14:20 +00:00
03feea82e4 If the glade file doesn't exists pop up an alert suggesting running 'make
Fri Sep 23 20:46:40 2005  Soeren Sandmann  <sandmann@redhat.com>

	* sysprof.c (build_gui): If the glade file doesn't exists pop up
	an alert suggesting running 'make install'

	* sysprof.c: Remove some commented out code
2005-09-24 00:47:22 +00:00
f3b78b7944 Cache BinFiles by filename.
Sat Jul  9 23:20:39 2005  Soeren Sandmann  <sandmann@redhat.com>

	* binfile.c (bin_file_new): Cache BinFiles by filename.

	* stackstash.c (stack_stash_free): Plug leak

	* process.c (process_free_maps): Plug leak

	* module/Makefile (install): Check that depmod exists before
	running it.
2005-07-10 03:28:35 +00:00
8e4696a4a1 Add version information
Sun Jun 19 15:39:50 2005  Søren Sandmann  <sandmann@redhat.com>

	* sysprof.c (on_about_activated): Add version information

	* configure.ac: Bump version to 0.91

	* README: Updates
2005-06-19 19:43:02 +00:00
088a822edc Disable type-ahead search for all the tree views.
Sun Jun 12 20:30:37 2005  Soeren Sandmann  <sandmann@redhat.com>

	* sysprof.c (build_gui): Disable type-ahead search for all the
	tree views.

	* sysprof.c (on_object_selection_changed): Call it from here

	* sysprof.c (expand_descendants_tree): New function that
	determines what nodes to expand in the descendatns view.

	* TODO
2005-06-13 00:33:51 +00:00
5cb9392775 Grab focus on the callers view, not the descendants view.
Thu May 26 01:10:45 2005  Soeren Sandmann  <sandmann@redhat.com>

	* sysprof.c (on_callers_row_activated): Grab focus on the callers
	view, not the descendants view.

	* sysprof.c (on_read): Add a short "dead" period after a reset,
	so that 'samples' will actually be 0 for a while.
2005-05-26 05:11:35 +00:00
402ffc9e4a update
Sat May 21 20:58:59 2005  Soeren Sandmann  <sandmann@redhat.com>

        * TODO: update

        * sysprof.c (on_menu_item_activated): New function.

        * sysprof.c (build_gui): Hook up menu items.

        * module/sysprof-module.c (init_module): Remove module_init/exit
        as they cause build failure on kernels < 2.6.11.
2005-05-22 01:01:20 +00:00
d9de1e5a36 Remove ref-counting since it didn't actually do any good.
Wed May 18 22:21:52 2005  Søren Sandmann  <sandmann@redhat.com>

        * module/sysprof-module.c: Remove ref-counting since it didn't
        actually do any good.

        * sysprof.c (load_module): Use g_spawn_command_line_sync() instaed
        of system().
2005-05-19 02:27:18 +00:00
55fd84676f Update the title bar on load/save
Sat May 14 16:36:32 2005  Søren Sandmann  <sandmann@redhat.com>

	* sysprof.c (set_application_title): Update the title bar on
	load/save

	* treeviewutils.c, sfile.c: Fix compiler warnings

	* Makefile.am: define PIXMAPDIR

Sat May 14 15:49:52 2005  Søren Sandmann  <sandmann@redhat.com>

	Auto*ify.

	* TODO: updates

	* AUTHORS, INSTALL, Makefile.am, NEWS, configure.ac: New files

	* module/Makefile: New file

	* module/sysprof-module.c, module/sysprof-module.h: Move these
	files to their own directy, as the kernel build system does not
	work very well with auto*.

	* sysprof.c, autogen.sh: Some auto* changes.
2005-05-14 20:38:03 +00:00
71db050480 Auto*ify.
Sat May 14 15:49:52 2005  Søren Sandmann  <sandmann@redhat.com>

	Auto*ify.

	* TODO: updates

	* AUTHORS, INSTALL, Makefile.am, NEWS, configure.ac: New files

	* module/Makefile: New file

	* module/sysprof-module.c, module/sysprof-module.h: Move these
	files to their own directy, as the kernel build system does not
	work very well with auto*.

	* sysprof.c, autogen.sh: Some auto* changes.
2005-05-14 19:53:53 +00:00
e6b3ae64bd *** empty log message *** 2005-05-10 13:07:20 +00:00
11c0561976 more updates
Sun May  8 16:31:32 2005  Søren Sandmann  <sandmann@redhat.com>

        * TODO: more updates

        * sysprof.c: Try loading the module before complaining
2005-05-08 20:34:04 +00:00
aaa38daad8 Restore lost wake_up().
Sun May  8 15:45:08 2005  Søren Sandmann  <sandmann@redhat.com>

	* sysprof-module.c (do_generate): Restore lost wake_up().

	* sfile.c: Comment out use of bz2.

	* Makefile: Add an install target. Add GLADE_DIR and PIXMAP_DIR

	* sysprof.c (build_gui): use GLADE_DIR and PIXMAP_DIR here.

	* TODO: Updates.
2005-05-08 19:49:26 +00:00
6906804784 Use getpagesize()
Sat Apr 30 16:57:23 2005  Soeren Sandmann  <sandmann@redhat.com>

	* process.c (PAGE_SIZE): Use getpagesize()

	* TODO: More updates
2005-04-30 20:59:01 +00:00
c824b74b9d Factor out some stuff in their own functions.
Sun Apr 17 00:20:41 2005  Soeren Sandmann  <sandmann@redhat.com>

        * sysprof.c (on_open_clicked): Factor out some stuff in their own
        functions.

        * sysprof.c (load_file): Idle handler to load files given on the
        command line.

        * sysprof.c (main): If a filename is passed on the command line,
        load it in an idle handler.
2005-04-17 06:03:38 +00:00
2b0ca11c6c +Sat Apr 16 14:15:55 2005 Soeren Sandmann <sandmann@redhat.com>
+
+       * TODO: Update
+
+       * sysprof-module.c (x_access_process_vm): On kernel 2.6.9 and
+       later use get_task_mm()/mmput() instead of directly accessing
+       task->mm.
+
2005-04-16 21:08:44 +00:00
a3b1e000e6 updates
Fri Apr 15 16:37:45 2005  Soeren Sandmann  <sandmann@redhat.com>

	* TODO: updates

	* sysprof.c (sorry): If you hit profile when the module isn't
	loaded, pop up an annoying dialog.

	* sysprof-module.c: Clean-ups, remove various unused abstractions.
2005-04-15 20:38:58 +00:00
b3c466debf Remove debug spew
Sat Apr  9 17:04:50 2005  Søren Sandmann  <sandmann@redhat.com>

	* Makefile: Remove debug spew

	* *: Add copyright notices
2005-04-09 21:17:24 +00:00
334f883d77 Load the icon, hook up "about" activation.
Fri Apr  8 20:48:58 2005  Søren Sandmann  <sandmann@redhat.com>

	* sysprof.c (build_gui): Load the icon, hook up "about"
	activation.

	* sysprof.c (on_about_activated): New function. Show an about
	dialog.

	* sysprof.c (struct Application): Add an icon field

	* TODO: Updates

	* sysprof-icon.png: Icon, drawn by Diana Fong
2005-04-09 00:51:25 +00:00
88c3bbb880 Add commented out debug spew.
Tue Apr  5 20:13:44 2005  Søren Sandmann  <sandmann@redhat.com>

	* process.c (process_ensure_map): Add commented out debug spew.

	* process.c (process_lookup_symbol): Remove all should_offset()
	function and all references to it.

	* binfile.c (bin_file_lookup_symbol): Document that address must
	be in file coordinates.

	* binfile.c (read_symbols): Remove misguided code that tried to
	guess the load address of the file. Instead, do all computations
	in "file coordinates". Also fix a memory leak. Add commented out
	debug spew.

	* binfile.c (separate_debug_file_exists): Fix signedness
2005-04-06 00:16:12 +00:00