Commit Graph

32 Commits

Author SHA1 Message Date
f925fab564 libsysprof-capture: Replace G_{UN,}LIKELY with SYSPROF_{UN,}LIKELY
This does the same thing for modern compilers, but without the GLib
dependency.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #40
2020-07-03 22:00:34 +01:00
8e28ac6e81 libsysprof-capture: Use assert() instead of g_assert()
Also use it instead of `g_return_if_fail()`.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #40
2020-07-03 22:00:34 +01:00
5636bbf4f0 libsysprof-capture: Use stdbool instead of gboolean
Another step towards dropping GLib as a dependency of
libsysprof-capture.

Unlike the previous commit which replaced GLib integer types with the
bitwise equivalent C standard types, `stdbool` is potentially a different
width from `gboolean`, so this is an ABI break.

It therefore involves some changes to callback functions in the tests
and tools, and in libsysprof.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #40
2020-07-02 21:07:11 +01:00
2c2cbf6343 libsysprof-capture: Use C11 types instead of GLib types
This is an almost entirely mechanical* conversion from (for example)
`gint` → `int`, `guint8` → `uint8_t`, etc.

It is not entirely complete, as many GLib functions are still used in
libsysprof-capture, which necessitate some use of GLib types.

It also avoids renaming `gboolean` → `bool` as that’s a slightly more
controversial change which will happen in the following commit.

*Code was manually realigned afterwards.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #40
2020-07-02 21:07:11 +01:00
988ad116a4 libsysprof-capture: check alignment in read length
We require aligned frames, so we might as well enforce it in the reader.
2020-02-23 14:30:06 -08:00
fd215a39a3 libsysprof-capture: check frame length overruns
If we got a corrupted frame, just stop reading forward immediately.
2020-02-23 14:26:13 -08:00
ca5c66245c libsysprof-capture: ignore some types when extending end_time 2020-02-15 22:17:23 -07:00
cb1b7d03fb libsysprof-capture: check frame types when peeking 2020-02-15 20:49:47 -07:00
b351e1a50a capture: add comment about frame tracking 2020-02-11 18:07:31 -08:00
33c81a3a9c memprof: add memory profiling using LD_PRELOAD
This brings over some of the techniques from the old memprof design.
Sysprof and memprof shared a lot of code, so it is pretty natural to
bring back the same callgraph view based on memory allocations.

This reuses the StackStash just like it did in memprof. While it
would be nice to reuse some existing tools out there, the fit of
memprof with sysprof is so naturally aligned, it's not really a
big deal to bring back the LD_PRELOAD. The value really comes
from seeing all this stuff together instead of multiple apps.

There are plenty of things we can implement on top of this that
we are not doing yet such as temporary allocations, cross-thread
frees, graphing the heap, and graphing differences between the
heap at to points in time. I'd like all of these things, given
enough time to make them useful.

This is still a bit slow though due to the global lock we take
to access the writer. To improve the speed here we need to get
rid of that lock and head towards a design that allows a thread
to request a new writer from Sysprof and save it in TLS (to be
destroyed when the thread exits).
2020-02-07 19:00:33 -08:00
532972beb6 libsysprof-capture: relicense as BSD-2-Clause-Patent
This allows embedding the static capture library without having to deal
with license incompatibility while retaining the patent clause. We want
as many consumers of the format as makes sense without the restriction
of what kind of app/library/tooling they are.

The application, sysprofd, libsysprof, and libsysprof-ui continue to be
GPLv3+.
2019-06-05 13:25:21 -07:00
7743a047b6 libsysprof-capture: add sysprof_capture_reader_find_file() 2019-05-29 15:13:01 -07:00
ffda366809 libsysprof-capture: add byte-order helper
This isn't needed for reading captures, but can be helpful when dealing
with embedded data such as file frames.
2019-05-29 15:13:01 -07:00
9410238d30 libsysprof-capture: skip frame when necessary 2019-05-29 15:13:01 -07:00
596d29496d libsysprof-capture: add file reader helper 2019-05-29 15:13:01 -07:00
336dae4d1f libsysprof-capture: add helper to list files in capture 2019-05-29 15:13:01 -07:00
7650d6e7c6 libsysprof-capture: add file chunk frame type 2019-05-29 15:13:01 -07:00
cc415c9140 libsysprof-capture: add log frame type
This is useful to interleave logs with the capture so that we can have
correlation without interjecting them into mark fields.
2019-05-29 15:13:01 -07:00
26bcf94888 whitespace 2019-05-29 15:13:01 -07:00
4067b5e592 libsysprof-capture: improve zero'ing when reading back 2019-05-29 15:13:01 -07:00
567f8a3a0f libsysprof-capture: shorten names by removing Frame 2019-05-29 15:13:01 -07:00
db9aea95ea libsysprof-capture: add metadata frame type
This will allow sources and aids to discover information about what was
done between capture loading and saving.
2019-05-29 15:13:00 -07:00
395c801476 libsysprof-capture: save filename if first save 2019-05-29 15:13:00 -07:00
8feeec782f libsysprof-capture: discover the end time if necessary
If we get a capture file without a valid end-time, we should just go
discover that up-front instead of dealing with it all over the place.
2019-05-29 15:13:00 -07:00
0c62fd13d4 libsysprof-capture: copy stat when dup'ing reader 2019-05-29 15:13:00 -07:00
aed80ea51f libsysprof-capture: add stats to reader when possible
We can also back-fill these when reading a capture file.
2019-05-29 15:13:00 -07:00
74ea7d197c libsysprof-capture: copy discovered end_time 2019-05-29 15:13:00 -07:00
2498b4cded libsysprof-capture: try harder to get proper end-time 2019-05-29 15:13:00 -07:00
7a0132ac92 libsysprof-capture: update end time for marks 2019-05-29 15:13:00 -07:00
c1e9b90f97 libsysprof-capture: whitespace cleanup 2019-05-29 15:13:00 -07:00
dcbcd3caf5 libsysprof-capture: remove dead code 2019-05-29 15:13:00 -07:00
53c718b708 build: rename all symbols to use sysprof_ as prefix
As we gain in usage, we need to be more careful about using a prefix
that will not collide with other symbols. So version 3 of our ABI will
change to using Sysprof/SYSPROF/sysprof as the various prefixes.

The soname/api version bump will happen later on this branch so that
things are easier to test up until then.
2019-05-29 15:12:59 -07:00