varun-r-mallya/py-libp2p
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/py-libp2p.git synced 2025-12-31 20:36:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #684 from guha-rahul/use_decapsulate

Browse Source 
fix: replace complex logic with decapsulate
This commit is contained in:
Manu Sheel Gupta
2025-06-16 04:37:14 -07:00
committed by GitHub
parent d2825af045 193e8f9cb8
commit 0caf8647c5
2 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
newsfragments/684.misc.rst Normal file
View File

@ -0,0 +1 @@
Uses the `decapsulate` method of the `Multiaddr` class to clean up the observed address.

11
tests/core/identity/identify/test_identify.py
View File

@ -56,16 +56,9 @@ async def test_identify_protocol(security_protocol):
)
# Check observed address
# TODO: use decapsulateCode(protocols('p2p').code)
# when the Multiaddr class will implement it
host_b_addr = host_b.get_addrs()[0]
cleaned_addr = Multiaddr.join(
*(
host_b_addr.split()[:-1]
if str(host_b_addr.split()[-1]).startswith("/p2p/")
else host_b_addr.split()
)
)
host_b_peer_id = host_b.get_id()
cleaned_addr = host_b_addr.decapsulate(Multiaddr(f"/p2p/{host_b_peer_id}"))
logger.debug("observed_addr: %s", Multiaddr(identify_response.observed_addr))
logger.debug("host_b.get_addrs()[0]: %s", host_b.get_addrs()[0])