Remove unnecessary parts from return_utils

This commit is contained in:
Pragyansh Chaturvedi
2025-10-06 05:02:02 +05:30
parent 7b0e8a2fca
commit 9aff614ff5

View File

@ -2,8 +2,6 @@ import logging
import ast
from llvmlite import ir
from pythonbpf.type_deducer import ctypes_to_ir
from pythonbpf.binary_ops import handle_binary_op
logger: logging.Logger = logging.getLogger(__name__)
@ -28,89 +26,6 @@ def _handle_none_return(builder) -> bool:
return True
def _handle_typed_constant_return(call_type, return_value, builder, ret_type) -> bool:
"""Handle typed constant return like: return c_int64(42)"""
expected_type = ctypes_to_ir(call_type)
if expected_type != ret_type:
raise ValueError(
f"Return type mismatch: expected {ret_type}, got {expected_type}"
)
# return_value = stmt.value.args[0].value
builder.ret(ir.Constant(ret_type, return_value))
logger.debug(f"Generated typed constant return: {call_type}({return_value})")
return True
def _handle_binop_return(arg, builder, ret_type, local_sym_tab) -> bool:
"""Handle return with binary operation: return c_int64(x + 1)"""
result = handle_binary_op(arg, builder, None, local_sym_tab)
if result is None:
raise ValueError("Failed to evaluate binary operation in return statement")
val, val_type = result
if val_type != ret_type:
raise ValueError(f"Return type mismatch: expected {ret_type}, got {val_type}")
builder.ret(val)
logger.debug(f"Generated binary operation return: {val}")
return True
def _handle_variable_return(var_name, builder, ret_type, local_sym_tab) -> bool:
"""Handle return of a variable: return c_int64(my_var)"""
if var_name not in local_sym_tab:
raise ValueError(f"Undefined variable in return: {var_name}")
var = local_sym_tab[var_name].var
val = builder.load(var)
if val.type != ret_type:
raise ValueError(f"Return type mismatch: expected {ret_type}, got {val.type}")
builder.ret(val)
logger.debug(f"Generated variable return: {var_name}")
return True
def _handle_wrapped_return(stmt: ast.Return, builder, ret_type, local_sym_tab) -> bool:
"""Handle wrapped returns: return c_int64(42), return c_int64(x + 1), return c_int64(my_var)"""
if not (
isinstance(stmt.value, ast.Call)
and isinstance(stmt.value.func, ast.Name)
and len(stmt.value.args) == 1
):
return False
arg = stmt.value.args[0]
# Case 1: Constant value - return c_int64(42)
if isinstance(arg, ast.Constant) and isinstance(arg.value, int):
return _handle_typed_constant_return(
stmt.value.func.id, arg.value, builder, ret_type
)
# Case 2: Binary operation - return c_int64(x + 1)
elif isinstance(arg, ast.BinOp):
return _handle_binop_return(arg, builder, ret_type, local_sym_tab)
# Case 3: Variable - return c_int64(my_var)
elif isinstance(arg, ast.Name):
if not arg.id:
raise ValueError("Variable return must have a type, e.g., c_int64")
return _handle_variable_return(arg.id, builder, ret_type, local_sym_tab)
else:
raise ValueError(f"Unsupported return argument type: {type(arg).__name__}")
def _is_xdp_name(name: str) -> bool:
"""Check if a name is an XDP action"""
return name in XDP_ACTIONS