varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: handle missing process gracefully

Browse Source 
If we get a request for a process that we have not captured any information
about then give it the "Unknown Process" symbol. That way we do not crash
and we also maintain our invariant of not mutating the hash table.
This commit is contained in:
Christian Hergert
2023-08-28 13:30:23 -07:00
parent aad3441fee
commit 00c02f0f18
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libsysprof/sysprof-document.c
View File

@ -79,6 +79,7 @@ struct _SysprofDocument
GHashTable *counter_id_to_values;
SysprofStrings *strings;
SysprofSymbol *missing_process;
EggBitset *allocations;
EggBitset *ctrdefs;
@ -519,6 +520,9 @@ sysprof_document_init (SysprofDocument *self)
self->cpu_info = g_list_store_new (SYSPROF_TYPE_CPU_INFO);
self->missing_process = _sysprof_symbol_new (g_ref_string_new (_("Unknown Process")),
NULL, NULL, 0, 0, SYSPROF_SYMBOL_KIND_UNWINDABLE);
self->counters = g_list_store_new (SYSPROF_TYPE_DOCUMENT_COUNTER);
self->counter_id_to_values = g_hash_table_new_full (NULL, NULL, NULL,
(GDestroyNotify)g_array_unref);
@ -768,6 +772,12 @@ sysprof_document_load_processes (SysprofDocument *self)
_sysprof_symbol_new (sysprof_strings_get (self->strings, parts[0]),
NULL, g_steal_pointer (&nick), 0, 0,
SYSPROF_SYMBOL_KIND_PROCESS);
g_clear_object (&process_info->shared_symbol);
process_info->shared_symbol =
_sysprof_symbol_new (sysprof_strings_get (self->strings, parts[0]),
NULL, NULL, 0, 0,
SYSPROF_SYMBOL_KIND_PROCESS);
}
}
}
@ -2108,7 +2118,7 @@ _sysprof_document_process_symbol (SysprofDocument *self,
info = _sysprof_document_process_info (self, pid, FALSE);
if (info == NULL)
g_error ("Failed to find info for PID %d", pid);
return self->missing_process;
if (info->symbol)
return info->symbol;