varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add FIXME about performance issue in stack_stash_add_trace()

Browse Source
This commit is contained in:
Søren Sandmann Pedersen
2010-04-23 11:26:17 -04:00
parent ded375462b
commit 298f92ff20
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
stackstash.c
View File

@ -220,6 +220,13 @@ stack_stash_add_trace (StackStash *stash,
StackNode *match = NULL; StackNode *match = NULL;
StackNode *prev; StackNode *prev;
/* FIXME: On x86-64 we don't get proper stacktraces which means
* each node can have tons of children. That makes this loop
* here show up on profiles.
*
* Not sure what can be done about it aside from actually fixing
* x86-64 to get stacktraces.
*/
prev = NULL; prev = NULL;
for (match = *location; match; prev = match, match = match->siblings) for (match = *location; match; prev = match, match = match->siblings)
{ {