varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysprof: rely on count from root node

Browse Source 
We have a valid count on root now so no need to deal with the 0 counts.
This commit is contained in:
Christian Hergert
2023-08-25 14:10:48 -07:00
parent 4a283a79c5
commit 35b75aa25b
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/sysprof/sysprof-flame-graph.c
View File

@ -326,12 +326,9 @@ sysprof_flame_graph_query_tooltip (GtkWidget *widget,
g_autoptr(GString) string = g_string_new (NULL); g_autoptr(GString) string = g_string_new (NULL);
SysprofSymbol *symbol = rect->node->summary->symbol; SysprofSymbol *symbol = rect->node->summary->symbol;
SysprofCallgraphNode *root = rect->node; SysprofCallgraphNode *root = rect->node;
guint64 weight = 0;
while (root->parent) while (root->parent)
root = root->parent; root = root->parent;
for (SysprofCallgraphNode *child = root->children; child; child = child->next)
weight += child->count;
g_string_append (string, symbol->name); g_string_append (string, symbol->name);
@ -346,9 +343,9 @@ sysprof_flame_graph_query_tooltip (GtkWidget *widget,
if (rect->node != root) if (rect->node != root)
g_string_append_printf (string, "%'u samples, %6.2lf%%", g_string_append_printf (string, "%'u samples, %6.2lf%%",
rect->node->count, rect->node->count,
rect->node->count / (double)weight * 100.); rect->node->count / (double)root->count * 100.);
else else
g_string_append_printf (string, "%'u samples", (guint)weight); g_string_append_printf (string, "%'u samples", (guint)root->count);
gtk_tooltip_set_text (tooltip, string->str); gtk_tooltip_set_text (tooltip, string->str);
@ -551,18 +548,14 @@ generate (GArray *array,
if (node->children != NULL) if (node->children != NULL)
{ {
graphene_rect_t child_area; graphene_rect_t child_area;
guint64 weight = 0;
child_area.origin.x = area->origin.x; child_area.origin.x = area->origin.x;
child_area.origin.y = area->origin.y; child_area.origin.y = area->origin.y;
child_area.size.height = area->size.height - ROW_HEIGHT - 1; child_area.size.height = area->size.height - ROW_HEIGHT - 1;
for (SysprofCallgraphNode *child = node->children; child; child = child->next)
weight += child->count;
for (SysprofCallgraphNode *child = node->children; child; child = child->next) for (SysprofCallgraphNode *child = node->children; child; child = child->next)
{ {
double ratio = child->count / (double)weight; double ratio = child->count / (double)node->count;
double width; double width;
width = ratio * area->size.width; width = ratio * area->size.width;