varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysprof: use hand cursor to indicate flamegraph interactivity

Browse Source 
You can click on flamegraph items (and soon) we will update the graph to
show you that node. Set the hand cursor when doing that so the user knows
that is an option.
This commit is contained in:
Christian Hergert
2023-08-25 13:36:19 -07:00
parent 22fe863230
commit 4a283a79c5
1 changed files with 31 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/sysprof/sysprof-flame-graph.c
View File

@ -47,6 +47,7 @@ struct _SysprofFlameGraph
GskRenderNode *rendered;
GArray *nodes;
SysprofCallgraphNode *root;
FlameRectangle *under_pointer;
double motion_x;
double motion_y;
@ -239,6 +240,30 @@ sysprof_flame_graph_measure (GtkWidget *widget,
}
}
static void
sysprof_flame_graph_set_motion (SysprofFlameGraph *self,
double x,
double y)
{
FlameRectangle *rect;
g_assert (SYSPROF_IS_FLAME_GRAPH (self));
self->motion_x = x;
self->motion_y = y;
rect = find_node_at_coord (self, x, y);
if (rect != self->under_pointer)
{
self->under_pointer = rect;
gtk_widget_set_cursor_from_name (GTK_WIDGET (self), rect ? "hand" : NULL);
}
gtk_widget_queue_draw (GTK_WIDGET (self));
}
static void
sysprof_flame_graph_motion_enter_cb (SysprofFlameGraph *self,
double x,
@ -248,10 +273,7 @@ sysprof_flame_graph_motion_enter_cb (SysprofFlameGraph *self,
g_assert (SYSPROF_IS_FLAME_GRAPH (self));
g_assert (GTK_IS_EVENT_CONTROLLER_MOTION (motion));
self->motion_x = x;
self->motion_y = y;
gtk_widget_queue_draw (GTK_WIDGET (self));
sysprof_flame_graph_set_motion (self, x, y);
}
static void
@ -263,10 +285,7 @@ sysprof_flame_graph_motion_motion_cb (SysprofFlameGraph *self,
g_assert (SYSPROF_IS_FLAME_GRAPH (self));
g_assert (GTK_IS_EVENT_CONTROLLER_MOTION (motion));
self->motion_x = x;
self->motion_y = y;
gtk_widget_queue_draw (GTK_WIDGET (self));
sysprof_flame_graph_set_motion (self, x, y);
}
static void
@ -276,10 +295,7 @@ sysprof_flame_graph_motion_leave_cb (SysprofFlameGraph *self,
g_assert (SYSPROF_IS_FLAME_GRAPH (self));
g_assert (GTK_IS_EVENT_CONTROLLER_MOTION (motion));
self->motion_x = 0;
self->motion_y = 0;
gtk_widget_queue_draw (GTK_WIDGET (self));
sysprof_flame_graph_set_motion (self, 0, 0);
}
static void
@ -619,6 +635,9 @@ sysprof_flame_graph_set_callgraph (SysprofFlameGraph *self,
g_clear_pointer (&self->nodes, g_array_unref);
self->root = NULL;
self->under_pointer = NULL;
gtk_widget_set_cursor_from_name (GTK_WIDGET (self), NULL);
if (callgraph != NULL)
{