varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-analyze: add note about symbolizing work

Browse Source
This commit is contained in:
Christian Hergert
2023-05-08 16:16:09 -07:00
parent 6daff5ac6e
commit 689599ef43
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libsysprof-analyze/sysprof-document-symbols.c
View File

@ -88,6 +88,20 @@ sysprof_document_symbols_add_traceable (SysprofDocumentSymbols *self,
g_assert (SYSPROF_IS_DOCUMENT_TRACEABLE (traceable));
g_assert (SYSPROF_IS_SYMBOLIZER (symbolizer));
/* TODO: We need to get the SysprofMountNamespace for the PID which must have
* already been compiled. We also need the list SysprofDocumentMmap so that we
* can get the build-id or inode to do various validation checks.
*
* It would be nice if that was all pre-compiled by time we get here and also
* re-usable on the SysprofDocument for other tooling that may need to access
* that.
*
* The symbolizer will need to gain API to use those too.
*
* Some of this will need to be done asynchronously as well because decoding
* from debuginfod could be quite costly in disk/network/time.
*/
n_addresses = sysprof_document_traceable_get_stack_depth (traceable);
addresses = g_alloca (sizeof (guint64) * n_addresses);
sysprof_document_traceable_get_stack_addresses (traceable, addresses, n_addresses);