build: use -Ddevelopment=true to set DEVELOPMENT_BUILD

And also, we use it as #ifdef, so never define it as 0.

meson.build

@@ -90,7 +90,9 @@ if get_option('libunwind')
 endif
 
 # Development build setup
-config_h.set('DEVELOPMENT_BUILD', version_split[1].to_int().is_odd())
+if get_option('development')
+  config_h.set10('DEVELOPMENT_BUILD', true)
+endif
 
 has_use_clockid = cc.has_member('struct perf_event_attr', 'use_clockid', prefix: '#include <linux/perf_event.h>')
 has_clockid = cc.has_member('struct perf_event_attr', 'clockid', prefix: '#include <linux/perf_event.h>')

meson_options.txt

@@ -1,3 +1,8 @@
+# If this is a development build, which is used for our Flatpak build
+# so that we have a different app-id (.Devel suffix) than the regular
+# application.
+option('development', type: 'boolean', value: 'false')
+
 # Optionally disable the GTK application in case you're building the
 # sysprof-cli only for your platform. Might be useful in IoT or various
 # server scenarios.

org.gnome.Sysprof.Devel.json

@@ -104,6 +104,7 @@
                 "--libdir=/app/lib",
                 "--buildtype=debugoptimized",
                 "-Dagent=true",
+                "-Ddevelopment=true",
                 "-Dlibsysprof=true",
                 "-Dgtk=true",
                 "-Dsysprofd=host"