mirror of
https://github.com/varun-r-mallya/sysprof.git
synced 2025-12-31 20:36:25 +00:00
Add percent signs; update TODO
This commit is contained in:
23
TODO
23
TODO
@ -30,7 +30,19 @@ Before 1.2:
|
||||
considered the same symbol if they have the same parent). In fact
|
||||
"has same parent" may be the correct criterion in all cases.
|
||||
|
||||
* It crashes sometimes.
|
||||
* See if we can make "In file <blah>" not be treated as a recursive function.
|
||||
Maybe simply treat each individual address in the file as a function.
|
||||
Or try to parse the machine code. Positions that are called are likely
|
||||
to be functions.
|
||||
|
||||
- Treat identical addresses as one function
|
||||
|
||||
- Treat all addresses within a library that don't have children are
|
||||
treated as one function.
|
||||
|
||||
This will have the effect of coalescing adjacent siblings without
|
||||
children. Which is what you want since you can't tell them apart
|
||||
anyway. It will never be a great experience though.
|
||||
|
||||
* Find out what is going on with kernel threads:
|
||||
|
||||
@ -167,11 +179,6 @@ Before 1.2:
|
||||
so we will have to store a list of expanded objects and keep that uptodate
|
||||
as the rows expands and unexpands.
|
||||
|
||||
* See if we can make "In file <blah>" not be treated as a recursive function.
|
||||
Maybe simply treat each individual address in the file as a function.
|
||||
Or try to parse the machine code. Positions that are called are likely
|
||||
to be functions.
|
||||
|
||||
* Give more sensible 'error messages'. Eg., if you get permission denied for
|
||||
a file, put "Permission denied" instead of "No map"
|
||||
|
||||
@ -829,6 +836,10 @@ Later:
|
||||
|
||||
-=-=-=-=-=-=-=-=-=-=-=-=-=-=- ALREADY DONE: -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
|
||||
|
||||
* It crashes sometimes.
|
||||
|
||||
I haven't seen any crashes in a long time
|
||||
|
||||
* Find out why the strings
|
||||
|
||||
_ZL11DisplayLineP20nsDisplayListBuilderRK6nsRectS3_R19nsLineList_iteratoriRiRK16nsDisplayListSetP12nsBlockFrame
|
||||
|
||||
14
sysprof.c
14
sysprof.c
@ -1533,6 +1533,8 @@ set_icons (Application *app)
|
||||
g_list_free (pixbufs);
|
||||
}
|
||||
|
||||
#define PCT_FORMAT "%.2f<span size='smaller'><span size='smaller'> %% </span></span>"
|
||||
|
||||
static gboolean
|
||||
build_gui (Application *app)
|
||||
{
|
||||
@ -1570,9 +1572,9 @@ build_gui (Application *app)
|
||||
col = add_plain_text_column (app->object_view, _("Functions"),
|
||||
OBJECT_NAME);
|
||||
add_double_format_column (app->object_view, _("Self"),
|
||||
OBJECT_SELF, "%.2f ");
|
||||
OBJECT_SELF, PCT_FORMAT);
|
||||
add_double_format_column (app->object_view, _("Total"),
|
||||
OBJECT_TOTAL, "%.2f ");
|
||||
OBJECT_TOTAL, PCT_FORMAT);
|
||||
app->object_selection = gtk_tree_view_get_selection (app->object_view);
|
||||
gtk_tree_view_column_set_expand (col, TRUE);
|
||||
|
||||
@ -1581,9 +1583,9 @@ build_gui (Application *app)
|
||||
col = add_plain_text_column (app->callers_view, _("Callers"),
|
||||
CALLERS_NAME);
|
||||
add_double_format_column (app->callers_view, _("Self"),
|
||||
CALLERS_SELF, "%.2f ");
|
||||
CALLERS_SELF, PCT_FORMAT);
|
||||
add_double_format_column (app->callers_view, _("Total"),
|
||||
CALLERS_TOTAL, "%.2f ");
|
||||
CALLERS_TOTAL, PCT_FORMAT);
|
||||
gtk_tree_view_column_set_expand (col, TRUE);
|
||||
|
||||
/* descendants view */
|
||||
@ -1591,9 +1593,9 @@ build_gui (Application *app)
|
||||
col = add_plain_text_column (app->descendants_view, _("Descendants"),
|
||||
DESCENDANTS_NAME);
|
||||
add_double_format_column (app->descendants_view, _("Self"),
|
||||
DESCENDANTS_SELF, "%.2f ");
|
||||
DESCENDANTS_SELF, PCT_FORMAT);
|
||||
add_double_format_column (app->descendants_view, _("Cumulative"),
|
||||
DESCENDANTS_CUMULATIVE, "%.2f ");
|
||||
DESCENDANTS_CUMULATIVE, PCT_FORMAT);
|
||||
gtk_tree_view_column_set_expand (col, TRUE);
|
||||
|
||||
/* screenshot window */
|
||||
|
||||
@ -186,7 +186,7 @@ double_to_text (GtkTreeViewColumn *tree_column,
|
||||
|
||||
text = g_strdup_printf (info->format, d);
|
||||
|
||||
g_object_set (cell, "text", text, NULL);
|
||||
g_object_set (cell, "markup", text, NULL);
|
||||
g_free (text);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user