varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-analyze: introduce [Unwindable] callgraph node

Browse Source 
This interjects a node for unwindable traces so that cost gets accounted
to the process, but is not just at the [process] graph item as that makes
it very hard to subtract to figure out what it was.

Instead just insert an [Unwindable] node and cost-account to that.
This commit is contained in:
Christian Hergert
2023-06-09 15:58:57 -07:00
parent 3f34c4625b
commit d2a38bf1a6
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libsysprof-analyze/sysprof-callgraph.c
View File

@ -84,6 +84,7 @@ G_DEFINE_FINAL_TYPE_WITH_CODE (SysprofCallgraph, sysprof_callgraph, G_TYPE_OBJEC
G_IMPLEMENT_INTERFACE (G_TYPE_LIST_MODEL, list_model_iface_init))
static SysprofSymbol *everything;
static SysprofSymbol *untraceable;
static void
sysprof_callgraph_summary_free_all (SysprofCallgraphSummary *summary)
@ -182,6 +183,7 @@ sysprof_callgraph_class_init (SysprofCallgraphClass *klass)
object_class->finalize = sysprof_callgraph_finalize;
everything = _sysprof_symbol_new (g_ref_string_new_intern ("[Everything]"), NULL, NULL, 0, 0);
untraceable = _sysprof_symbol_new (g_ref_string_new_intern ("[Unwindable]"), NULL, NULL, 0, 0);
}
static void
@ -308,6 +310,18 @@ sysprof_callgraph_add_traceable (SysprofCallgraph *self,
g_assert (n_symbols <= stack_depth);
/* Sometimes we get a very unhelpful unwind from the capture
* which is basically a single frame of "user space context".
* That means we got no amount of the stack, but we should
* really account costs to something in the application other
* than the [Application] entry itself so that it's more clear
* that it was a corrupted unwind when recording.
*/
if (n_symbols == 1 &&
symbols[0]->is_context_switch &&
final_context == SYSPROF_ADDRESS_CONTEXT_USER)
symbols[0] = untraceable;
/* We saved 3 extra spaces for these above so that we can
* tack on the "Process" symbol and the "Everything" symbol.
* If the final address context places us in Kernel, we want