varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-analyze: add fallback Kernel symbols

Browse Source 
If we fail to load a /proc/kallsyms.gz from the capture file, we can still
provide an "In Kernel+address" symbol. I prefer this to force loading the
kallsyms from the current system because that:

 1. Requires privileged access and therefore means potentially an
    authorization dialog.
 2. May not even be from the same system that the capture was recorded
    leading to incorrect symbolization.
This commit is contained in:
Christian Hergert
2023-05-23 10:57:26 -07:00
parent c3f67eb988
commit fd69b1051c
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/libsysprof-analyze/sysprof-kallsyms-symbolizer.c
View File

@ -251,7 +251,7 @@ sysprof_kallsyms_symbolizer_symbolize (SysprofSymbolizer *symbolizer,
return NULL;
if (address < self->low || address >= self->high)
return NULL;
goto failure;
symbols = &g_array_index (self->kallsyms, KernelSymbol, 0);
n_symbols = self->kallsyms->len;
@ -260,7 +260,7 @@ sysprof_kallsyms_symbolizer_symbolize (SysprofSymbolizer *symbolizer,
right = n_symbols;
mid = n_symbols / 2;
for (;;)
while (left <= right)
{
const KernelSymbol *ksym = &symbols[mid];
const KernelSymbol *next = &symbols[mid+1];
@ -281,7 +281,17 @@ sysprof_kallsyms_symbolizer_symbolize (SysprofSymbolizer *symbolizer,
mid = left + ((right-left) / 2);
}
g_assert_not_reached ();
failure:
{
char name[64];
g_snprintf (name, sizeof name, "In Kernel+0x%"G_GINT64_MODIFIER"x", address);
return _sysprof_symbol_new (sysprof_strings_get (strings, name),
g_ref_string_acquire (linux_string),
NULL,
address,
address + 1);
}
}
static void