Commit Graph

2442 Commits

Author SHA1 Message Date
8aa55a7b2d sysprof: attempt to highlight to root of flamegraph 2023-08-28 15:44:41 -07:00
279e8ae397 sysprof: leave process 0 visible
This can be a number of samples, and is worthwhile for debugging unless
toggled off in the view options.
2023-08-28 15:03:56 -07:00
7150db0045 sysprof: add ui to toggle ignoring kernel processes 2023-08-28 15:03:56 -07:00
c4e96bb314 libsysprof: add flag to ignore kernel processes 2023-08-28 15:03:56 -07:00
8f26c0037d libsysprof: sniff various forms of kernel process names
This is by no means perfect, but it gets the kernel tasks running on my
machine out of the profiles. We will no doubt need to add more in the
future, or find a way to record a flag for that in the capture format.
2023-08-28 15:03:53 -07:00
fd980eca68 libsysprof: always create pid0 info
That way we don't risk showing "Unknown Process" if we get stack traces
recorded with a 0 pid (which can happen from Perf).
2023-08-28 14:55:43 -07:00
310e43f166 sysprof: add various action symbolic icons
We *should* be able to rely on these icons but not everyone has an up to
date system, particularly if not running GNOME.

Related #93
2023-08-28 14:22:45 -07:00
88dc13d869 sysprof: scroll to the bottom of the flame graph
Unfortunately we don't have a good way to do this in GtkScrolledWindow
where you have an initial gravity pulling you to the bottom of a viewport.

We might be able to fake it with a focusable widget, but that sounds like
more work than just animating to the bottom of the viewport.

Related #93
2023-08-28 14:13:59 -07:00
dc15089133 sysprof: add animation helpers
Reluctantly adding animation helpers so we can do some automated scrolling.
2023-08-28 14:12:43 -07:00
a60bc04de2 sysprof: add UI to toggle merge-similar-processes flags
Related #93
2023-08-28 13:34:11 -07:00
cdfae5f7b9 libsysprof: add callgraph flag to merge similar processes
This is the backing implementation to allow for merging multiple processes
which have identical comm[] fields.
2023-08-28 13:34:11 -07:00
00c02f0f18 libsysprof: handle missing process gracefully
If we get a request for a process that we have not captured any information
about then give it the "Unknown Process" symbol. That way we do not crash
and we also maintain our invariant of not mutating the hash table.
2023-08-28 13:34:11 -07:00
aad3441fee libsysprof: normalize binary path/nick empty strings
If we get an empty string, just normalize that to NULL so that we can be
more likely to match equality checks via hash comparison.

Additionally, break hashes out into two so that we can improve the
situation where some symbols do not have paths but still match. This
can happen with bundled symbols.
2023-08-28 13:33:37 -07:00
e6d9f7c849 sysprof: fix ownership transfer of treelistrow
Fixes #92
2023-08-28 12:20:27 -07:00
a3a2b02b0d libsysprof: assert hashtable stays read-only
We only mutate this during loading of the document so that we can be
confident in multi-threaded workers after loading. This just asserts
that invariant holds true.
2023-08-28 12:19:16 -07:00
8d1ca4bd0d Fix typo in sysprof-greeter.ui 2023-08-28 13:51:33 +00:00
0a12163f6e sysprof: use flatpak-spawn when inside of flatpak
Unless the argv already is calling flatpak-spawn, try to run the process
through the host using flatpak-spawn.
2023-08-27 14:27:00 -07:00
5c9c20621e sysprof: add support for left-heavy sorting of flamegraph
Related #93
2023-08-27 13:45:09 -07:00
9f0a214a69 sysprof: include file/category in tooltips 2023-08-25 17:41:47 -07:00
fd3e5af1fa libsysprof: add category name private helper 2023-08-25 17:41:34 -07:00
d1b228bf28 sysprof: add menu button for callgraph options
This is useful for when we are viewing things like flamegraphs which can
take advantage of options in the callgraph.

Also add some labels for the header bar buttons.
2023-08-25 16:49:27 -07:00
75c7a99339 sysprof: dive into flamegraph node upon click
This makes the graphs interactive finally where you can select a node and
see the children of it directly. Click down the stack to return to a
larger view.
2023-08-25 15:44:27 -07:00
cd06a025a4 sysprof: render from alternate root to real root
This helps with the situation where we are going to render the parents
of the selected root first, and want them to take the whole width. Next
step is to support invalidation of the rendering.
2023-08-25 15:29:23 -07:00
35b75aa25b sysprof: rely on count from root node
We have a valid count on root now so no need to deal with the 0 counts.
2023-08-25 14:11:55 -07:00
4a283a79c5 sysprof: use hand cursor to indicate flamegraph interactivity
You can click on flamegraph items (and soon) we will update the graph to
show you that node. Set the hand cursor when doing that so the user knows
that is an option.
2023-08-25 13:36:19 -07:00
22fe863230 sysprof: add description for process items 2023-08-25 13:13:34 -07:00
174d5f2cd4 sysprof: add tooltips to chart layer
Now that we do some filtering on these to not show too many items per row,
this can be enabled. Previously it could *really* slow things down due to
all the app<->compositor traffic it causes.
2023-08-25 12:56:24 -07:00
8a43440f6a sysprof: fix double accounting in recursion
We don't want to cost-account the same summary multiple times while walking
up to the root. Otherwise, you can get items which come out to a percentage
of > 100% which is not exactly what you're expecting to see as a normalized
value.
2023-08-25 12:43:57 -07:00
a28353eb76 sysprof: sort callgraph models incrementally
This represented a large stall when loading the window, and also results
in doing a bunch of work twice as we set the model (then again the time
range).

So instead, just do it incrementally and let the functions list backfill in
a bit.
2023-08-25 12:42:59 -07:00
00554090d8 libsysprof: check for null node before setting toplevel 2023-08-25 12:42:07 -07:00
3de88108ce libsysprof: ensure we update count for root node 2023-08-25 12:41:52 -07:00
677c6a19a7 libsysprof: fix kernel (Linux) categorization 2023-08-25 11:37:17 -07:00
352f1b2038 sysprof: include sample count and percentage in tooltip 2023-08-25 11:27:55 -07:00
be9cf3d5f8 sysprof: add stable alpha variation
This is something that original flamegraphs do to aid in seeing adjacent
towers. We want that too, but we need it to be stable across redraws. Use
the hash of the symbol rather than g_random_double_range() for that.
2023-08-25 11:15:26 -07:00
ec03b13b49 sysprof: tweak font size 2023-08-25 11:15:26 -07:00
47ff438b20 sysprof: add hooks to track selection changes 2023-08-24 17:53:02 -07:00
9776f1f41b sysprof: add tooltip for flamegraphs 2023-08-24 17:17:15 -07:00
4a97716f5f sysprof: generate flamegraph rectangles off thread
Then cache the render tree so that we can have highlight nodes without
having to use children widgets.
2023-08-24 17:05:28 -07:00
507c0e79c2 libsysprof: move callgraph sorting to thread worker 2023-08-24 14:13:17 -07:00
ec9d930d58 sysprof: tweak drawing of flame graph 2023-08-24 13:04:16 -07:00
7c34f8a687 sysprof: fixed row height and text labels
This makes things look a bit more like flamegraphs.pl in the sense that we
have some labels and separation between rows. Also, use a ScrolledWindow so
that we can have much taller graphs to accommodate deep stack traces.

We might want to jump to the bottom at some point, but this gets things in
place for now. Icicle graphs are another option (invert).
2023-08-24 12:00:42 -07:00
debd576c2e sysprof: sort flamegraph alphabetically for X axis
This is what flamegraph.pl does, and there is somewhat an expectation that
we match that.
2023-08-24 11:21:28 -07:00
4d6f0fe061 sysprof: use Flamegraph for naming
That is a closer match to callgraph, and the original name anyway.
2023-08-23 16:32:20 -07:00
5a5e269e7c sysprof: fix category and weights for drawings 2023-08-23 16:16:28 -07:00
f9dabe582a sysprof: some work on graph recursion 2023-08-23 16:01:14 -07:00
790408f10c sysprof: allow caller to check for invisible nodes 2023-08-23 16:01:00 -07:00
cfc40225c9 sysprof: add very simple graph generation
This is not yet interactive, nor very descriptive of what is contained
within it.
2023-08-23 15:25:41 -07:00
9de7199373 sysprof: add helper to get category color 2023-08-23 15:25:07 -07:00
be2970929f sysprof: bind callgraph to flame graph 2023-08-23 14:32:18 -07:00
b80c8b8b5b libsysprof: always increment count for callgraph nodes
This shouldn't affect categorizing because that only uses the value if
is_toplevel. But with this added, we can use the count for weights in
other tooling w/o needing augmentation.
2023-08-23 14:32:04 -07:00